search

snowleopard / build

Build Systems à la Carte
MIT License
247 stars 18 forks source link

Switch to newtype Task #12

Closed snowleopard closed 6 years ago

snowleopard commented 6 years ago

Another comparison of type Task and newtype Task.

snowleopard commented 6 years ago

@simonpj @ndmitchell Finally managed to rewrite everything to newtype. Sorry I couldn't make it in time for the artefact evaluation.

I think the new version is clearly simpler, so we should go for it. If you disagree please shout.

snowleopard commented 6 years ago

By the way, I failed to convert the function Build.Task.toTasks to use newtype Task but it's not very important. Still, a minor annoyance.

ndmitchell commented 6 years ago

Looks awesome - much nicer. I wouldn't worry about toTasks, it's not actually important to what we are claiming anyway.

snowleopard commented 6 years ago

@ndmitchell Thanks! Merged.