Reduce code duplication by using type class Trace - Githubissues

snowleopard / build

Build Systems à la Carte

MIT License

242 stars 18 forks source link

Reduce code duplication by using type class Trace #4

Closed snowleopard closed 6 years ago

snowleopard commented 6 years ago

At the moment we have a lot of code duplication in Build.Strategy.

Can we get rid of it using type classes?

In this PR I'd like to try encoding the overall pattern that all tracing strategies use:

Return the given (current) value if the key does not need to be rebuild.
Return the cached value if it can be found in i without rerunning the Task.
Return the value computed by running the Task.

Note that the remaining A and M variants also have a lot of duplication and could probably be abstracted over c.

snowleopard commented 6 years ago

Closing, since I found a better way to reduce code duplication.