search

snowleopard / hadrian

Hadrian: a new build system for the Glasgow Haskell Compiler. Now merged into the GHC tree!
https://gitlab.haskell.org/ghc/ghc/tree/master/hadrian
MIT License
208 stars 39 forks source link

build.cabal.sh permission bits changed by running build #517

Closed izgzhen closed 6 years ago

izgzhen commented 6 years ago 
diff --git a/build.cabal.sh b/build.cabal.sh
old mode 100644
new mode 100755
snowleopard commented 6 years ago

I'm confused. Are you saying Hadrian changed permissions of this file? I don't see how it could do that!

snowleopard commented 6 years ago

Oops, it does do that actually. I found this in build.sh:

# By default on Linux/MacOS we build Hadrian using Cabal
chmod a+x "$root/build.cabal.sh"
(. "$root/build.cabal.sh" "$@")

I remember now: without this it was failing on CI. Perhaps, we should move this to CI scripts?

izgzhen commented 6 years ago

Perhaps, we should move this to CI scripts?

It sounds reasonable to me. Or we could change the permission bit once and for all.

snowleopard commented 6 years ago

@izgzhen Ah, so git can actually store permission bits? In this case yes, that would be a better solution. Could you send a PR?

snowleopard commented 6 years ago

I've reopen the issue to also fix build.sh -- see the PR above.