search

snowleopard / hadrian

Hadrian: a new build system for the Glasgow Haskell Compiler. Now merged into the GHC tree!
https://gitlab.haskell.org/ghc/ghc/tree/master/hadrian
MIT License
208 stars 39 forks source link

Added libraries for validate #525

Closed chitrak7 closed 6 years ago

chitrak7 commented 6 years ago

Added libraries check-ppr and check-api-annotations to stage2 packages.

snowleopard commented 6 years ago

Thanks @chitrak7! See my comment above. Adding these two utilities into the default build will slow down Hadrian unnecessarily. We only want to build them in the validate rule, before running the testsuite.

snowleopard commented 6 years ago

@chitrak7 Can you rebase this PR and implement the above suggestion? I'd like to merge this so we can reduce the number of validate failures.

chitrak7 commented 6 years ago

@snowleopard Can I do this task on 1st as I have my end semesters going on now.

snowleopard commented 6 years ago

@chitrak7 Sure, no problem!

This is a small fix so if we get blocked on this, we'll just complete this PR ourselves and merge it.