Follow-up to #531 - Githubissues

snowleopard / hadrian

Hadrian: a new build system for the Glasgow Haskell Compiler. Now merged into the GHC tree!

https://gitlab.haskell.org/ghc/ghc/tree/master/hadrian

MIT License

208 stars 39 forks source link

Follow-up to #531 #540

Closed snowleopard closed 6 years ago

snowleopard commented 6 years ago

Here is a list of things that I'd like to look at after #531 has been merged:

[x] Try to break import loops by adding more .Type modules.
[x] Work on #538 to fix -c.
[x] Figure out where we can replace buildDir with contextDir.
[x] Finish the Settings/Packages.hs story.
[x] Move ghctags and haddockback to Stage2.
[x] Clean up remaining ghc-cabal bits.
[x] Clean up remaining installation infrastructure.

alpmestan commented 6 years ago

-c is fixed (#571).

snowleopard commented 6 years ago

@alpmestan Yep, checked the box.

snowleopard commented 6 years ago

I finished merging all package-specific arguments into Settings/Packages.hs in #622.

snowleopard commented 6 years ago

I'm moving Haddock and ghctags to Stage2, since this is what Make build system does. I haven't found a justification for moving Haddock from Stage2 to Stage1 in #531.

@alpmestan If this is wrong, please shout.

alpmestan commented 6 years ago

There probably isn't a justification. I don't think this should be a problem. As long as you make sure everything still happily builds, we should be fine :-)

snowleopard commented 6 years ago

@alpmestan Thanks, done :)

snowleopard commented 6 years ago

I think I'm done with this issue.

Figure out where we can replace buildDir with contextDir.

The answer to this appears to be "No, we need to keep buildDir", since the Cabal library insists on keeping build artefacts in the build subdirectory.