snowleopard / hadrian

Hadrian: a new build system for the Glasgow Haskell Compiler. Now merged into the GHC tree!
https://gitlab.haskell.org/ghc/ghc/tree/master/hadrian
MIT License
208 stars 39 forks source link

Move rts I/O Functions in different namespace. #542

Closed Mistuke closed 6 years ago

Mistuke commented 6 years ago

Hi,

I'll be landing https://phabricator.haskell.org/D4416 soon but that requires some new build arguments for the rts due to Linux. The build will fail without this change.

The flag controls name-mangling of some I/O functions. Without it they'll be in the default namespace and the build will fail with an unknown symbol.

Also I noticed xxhash.c's optimization flags were not the same as Make, so I've corrected those.

angerman commented 6 years ago

LGTM.

angerman commented 6 years ago

Build failures are not due to this PR.

snowleopard commented 6 years ago

@Mistuke Many thanks for the PR! Hope we'll soon fix Hadrian on all major platforms and will have reliable CI back.

@angerman And thank you for reviewing and merging.