snowleopard / hadrian

Hadrian: a new build system for the Glasgow Haskell Compiler. Now merged into the GHC tree!
https://gitlab.haskell.org/ghc/ghc/tree/master/hadrian
MIT License
208 stars 39 forks source link

cmd failed but stdin is missing from debugging info #545

Closed izgzhen closed 5 years ago

izgzhen commented 6 years ago

For example, the #543 probably failed between the following line

https://github.com/snowleopard/hadrian/blob/9a46249e974c99a2015d7bba514b252c31ff8575/src/Builder.hs#L259-L266

You would see a - at the end of Command: /usr/local/bin/ghc-pkg --global-package-db _build/stage0/lib/package.conf.d register -v0 -, but this isn't complete since some stdin need be fed into the command line in order to run.

If a command failed, we might need to throw this out explicitly

angerman commented 6 years ago

@izgzhen so you want to dump Stdin to the console if the command failed? Am I understanding this right? If so, what would probably be something that needs to be addressed in Shake's cmd?

izgzhen commented 6 years ago

so you want to dump Stdin to the console if the command failed? Am I understanding this right? If so, what would probably be something that needs to be addressed in Shake's cmd?

I think we can address it either in Shake or in this repo (by getting Exit out).

ndmitchell commented 6 years ago

I created a Shake issue https://github.com/ndmitchell/shake/issues/577

snowleopard commented 5 years ago

I believe this has been fixed.