search

snowleopard / hadrian

Hadrian: a new build system for the Glasgow Haskell Compiler. Now merged into the GHC tree!
https://gitlab.haskell.org/ghc/ghc/tree/master/hadrian
MIT License
208 stars 39 forks source link

Rename GhcPkgMode::Clone to GhcPkgMode::Register? #546

Closed izgzhen closed 6 years ago

izgzhen commented 6 years ago

@alpmestan I am curious why it is called Clone, since the sub-command it uses is register.

thanks!

alpmestan commented 6 years ago

@izgzhen IIRC this particular builder is used for "cloning" the package database of the stage 0 compiler (copying it somewhere under our build root). @angerman Do I remember correctly?

angerman commented 6 years ago

@alpmestan that is correct. Clone is dump + register.

angerman commented 6 years ago

I should note: I mean describe if I say dump :(

izgzhen commented 6 years ago

It makes sense, thanks!