Open snowleopard opened 6 years ago
I'd rather argue that we should locate touchy.exe
in bin
rather than lib
.
@angerman I agree, but this requires changes to GHC.
In the meantime I suggest we follow what GHC does. It looks a bit inconvenient but not a big deal.
@snowleopard We don't put our binaries under .../lib/bin
anymore though with our relocatable builds. Do you see a good reason why we should not put touchy
right next to the ghc
binaries that'll use it, under <build root>/stage<N>/bin
?
(Sorry, I've been mostly offline last week).
So it looks like it would be a required change to the aclocal.m4
file, to change the touchy
path if we are building with hadrian? Wasn't there some discussion about adding --hadrian
to configure
?
Alternatively, we could patch the lib/settings
file in hadrian, after building ghc
.
Do you see a good reason why
I don't, but people who chose lib
might... I'm not the one who will be reviewing this patch to GHC.
Wasn't there some discussion about adding
--hadrian
to configure?
@angerman Yes, there was such suggestion, but I'm not a fan of it. I don't want to add another potential way to screw up when using Hadrian.
For now, I've just pushed a simple commit (#572) that moves touchy
to lib/bin
, to follow the current file layout used in GHC. I'd like to have a working CI as soon as possible, so I don't want to be blocked by a review of the potential patch to GHC. When/if GHC moves touchy
to bin
we'll simply revert #572.
UPDATE: The original issue is now fixed in #572, but we might want to move
touchy
tobin
.After #568 we have a new Windows-specific failure:
Looks like in #531
touchy
was relocated to thebin
directory. I guess we should bring it back tolib/bin
.