Closed izgzhen closed 6 years ago
I am actually reverting a change I've done in https://github.com/snowleopard/hadrian/pull/401/files. I tried to understand what is my motivation but found it hard to justify this by comparing to the latest HEAD. I think we can merge this as long as CI passed and no one jumps out and objects it.
I think we should just make one of the CI instances (e.g. the selftest
one) fail if there are any warnings. In this case there are warnings about unused code, which is difficult to spot while reviewing a PR, but easy to check by the compiler. Perhaps, we could also hook up @ndmitchell's Weeder :)
@angerman I've updated the code, thanks! I guess there will inevitably be some dead code, but let's do it when we have to.
@snowleopard Dead code check is a good idea! https://github.com/snowleopard/hadrian/issues/584
@izgzhen Thanks, merged!
fixes #581