Closed chitrak7 closed 6 years ago
@chitrak7 Thanks! I've added some comments.
@chitrak7 Do you have any idea at this point of why we're still skipping so many tests? (this is not a comment/request on the actual patch, I'm just curious and this still feels like the best place to ask)
@alpmestan I do not exactly know that, Can you give me pointers on where to look. More importantly, why does testsuite decide to skip a test.
@snowleopard Can you please see why recursive rule failure is coming?
@alpmestan I do not exactly know that, Can you give me pointers on where to look. More importantly, why does testsuite decide to skip a test.
You should see some information about this in the testsuite driver initialization part of the output (early on, when you look at the full log).
@alpmestan I believe skipped tests are because of using "fast" option with testsuite.
@chitrak7 OK. If you ever get a chance to, it would be terrific to add a way to run the equivalent of ./validate --slow
. If not, I'll do it. But not in this PR of course. Thanks for the reply and taking a look at what was going on :+1:
@chitrak7 Please resolve merge conflicts.
Can you please see why recursive rule failure is coming?
@chitrak7 The recursive rule failure is unrelated to your PR. I think the reason is #599.
@chitrak7 Something is wrong, looks like you've duplicated the recent commits instead of rebasing.
@snowleopard I have reset my repository and made necessary changes. It is currently failing due to "llvm" issue. I will resend it once that PR Lands.
Should the title of this PR be "Add support for nofib testsuite" ? We already support hadrian test
.
No, support for nofib was the goal of #599, not this PR. This PR is about supporting the execution of more tests, and about building things that are required by some of them which were not built previously. It still skips a whole bunch of tests but maybe @chitrak7 could provide an overview of the state of things with/without the commits from his branch? In terms of # of tests being run, # of broken test expectations.
I just noticed that this PR also add a new file src/Rules/Nofib.hs
...
Right, my commits somehow did not get merged properly apparently. But you cann tell they've already been merged because they refer to the PR number.
Hi @snowleopard @angerman, I have pushed the work done with validation implementation.
@chitrak7 Thanks! Let's come back to this PR once we fix Hadrian.
OK, I think we can merge this -- there are a few minor issues but we can fix them later.
@alpmestan Do you have any further comments?
No, let's merge :+1:
Merged. Many thanks @chitrak7, and everyone else for the review!
@snowleopard @angerman Validation result after this push: SUMMARY for test run started at Mon May 14 00:32:42 2018 IST 0:20:37 spent to go through 6359 total tests, which gave rise to 23523 test cases, of which 17231 were skipped