search

snowleopard / hadrian

Hadrian: a new build system for the Glasgow Haskell Compiler. Now merged into the GHC tree!
https://gitlab.haskell.org/ghc/ghc/tree/master/hadrian
MIT License
208 stars 37 forks source link

Added featues to binary distribution #623

Closed chitrak7 closed 6 years ago

chitrak7 commented 6 years ago

The code is working on linux now. @angeman @alpmestan @snowleopard

chitrak7 commented 6 years ago

I have made the necessary changes @alpmestan @angerman @snowleopard an tested it on linux. Also, we are not shipping ghci, should I create a separate PR to do so?

chitrak7 commented 6 years ago

@alpmestan Should we ship c header files as well. It is probably required by hsc2hs. If yes, then I can create a separate PR.

alpmestan commented 6 years ago

We do need to ship some C header files yes. This is what my bindist of 8.4.3 comes with:

$ ls /nix/store/a5z79ybg660ymjdq8mh4mcr7p6cbpxg4-ghc-8.4.3-with-packages/lib/ghc-8.4.3/include/
Cmm.h               HsFFI.h     Rts.h     Stg.h  ffitarget.h    ghcconfig.h    ghcversion.h  stg/
DerivedConstants.h  MachDeps.h  RtsAPI.h  ffi.h  ghcautoconf.h  ghcplatform.h  rts/
chitrak7 commented 6 years ago

Hi @alpmestan, I have figured out how to ship includes. But since this PR is already pretty big, I think I should send a separate PR once this is merged.

chitrak7 commented 6 years ago

Also, I have compared the our bindist with bindist ofghc-8.2.1 and couldn't find much difference.

alpmestan commented 6 years ago

@chitrak7 As you prefer. Most of your PR (in terms of # of lines changed) is about your Makefile changes, so it's still quite easily reviewable, so you can feel free to use this PR too unless @snowleopard objects.

snowleopard commented 6 years ago

@chitrak7 Thanks, looks good to me.

@alpmestan Any further comments from you?

alpmestan commented 6 years ago

No, looks good to me.

snowleopard commented 6 years ago

Thanks, merged!