For executables, we should read the `main-is` field from the cabal file.

snowleopard / hadrian

Hadrian: a new build system for the Glasgow Haskell Compiler. Now merged into the GHC tree!

https://gitlab.haskell.org/ghc/ghc/tree/master/hadrian

MIT License

208 stars 39 forks source link

For executables, we should read the `main-is` field from the cabal file. #627

Closed sighingnow closed 6 years ago

sighingnow commented 6 years ago

Previously, we simply treat file name for Main module as Main.hs to build executables. That doesn't work for the timeout program. This patch fixes the problem.

sighingnow commented 6 years ago

This pr blocks #499 .

alpmestan commented 6 years ago

Looks reasonable to me.

snowleopard commented 6 years ago

@sighingnow Many thanks! Just a couple of minor comments above. Please add a comment to clarify what's going on.

sighingnow commented 6 years ago

@snowleopard Could we land this now ?

snowleopard commented 6 years ago

@sighingnow Yes, thanks! I'm just waiting for at least one green light from Travis (I believe 8.2.2 was fine).

snowleopard commented 6 years ago

Merged.

sighingnow commented 6 years ago

Thanks !