search

snowleopard / hadrian

Hadrian: a new build system for the Glasgow Haskell Compiler. Now merged into the GHC tree!
https://gitlab.haskell.org/ghc/ghc/tree/master/hadrian
MIT License
208 stars 39 forks source link

implement the equivalent of D4955 for hadrian #648

Closed alpmestan closed 6 years ago

alpmestan commented 6 years ago

This addresses #642.

@snowleopard I'm using CabalFlags for now to keep it consistent. I also think it's not necessarily a good idea to throw everything at GhcCabal Conf instead, since we do not use ghc-cabal anymore. Since it's at least worth discussing, I just went with uniformity and passed the flags through CabalFlags.

snowleopard commented 6 years ago

@alpmestan Thanks, this looks good to me, but see a minor comment above.

Is the title wrong? I think the relevant Phab is D4955:

https://phabricator.haskell.org/D4955#inline-38448

I also think it's not necessarily a good idea to throw everything at GhcCabal Conf instead, since we do not use ghc-cabal anymore

Oops, I think I simply mixed up the two. Of course, we better get rid of GhcCabal.

alpmestan commented 6 years ago

I'm now using stage2 and I fixed the title. Thanks!

snowleopard commented 6 years ago

@alpmestan Thanks! I'll let CI finish and merge.