search

snowleopard / hadrian

Hadrian: a new build system for the Glasgow Haskell Compiler. Now merged into the GHC tree!
https://gitlab.haskell.org/ghc/ghc/tree/master/hadrian
MIT License
208 stars 39 forks source link

remove unwanted '-O0's in Settings.Packages #674

Closed alpmestan closed 5 years ago

alpmestan commented 5 years ago

It turns out we don't see the bugs if we just keep the -fno-omit-... etc flags. This also "resolves" several failing tests (see comment in #669) !

alpmestan commented 5 years ago

Uh, well, yes, it makes sense. We're taking a compilation time hit in exchange of better execution time.

sighingnow commented 5 years ago

If we don't pass -O0, we don't need to add the extra flags -fno-omit-interface-pragmas and -fno-ignore-interface-pragmas.

alpmestan commented 5 years ago

Indeed. Done in https://github.com/snowleopard/hadrian/pull/675.