snowleopard / hadrian

Hadrian: a new build system for the Glasgow Haskell Compiler. Now merged into the GHC tree!
https://gitlab.haskell.org/ghc/ghc/tree/master/hadrian
MIT License
208 stars 37 forks source link

.travis.yml: update OS X script to test a GHC patch for #614 #678

Closed alpmestan closed 6 years ago

alpmestan commented 6 years ago

I'm hoping to see the OS X travis job go green... =)

snowleopard commented 6 years ago

@alpmestan I'm afraid we already tried the #if defined(DEBUG) trick -- and it doesn't work. We don't process Cabal files with CPP.

snowleopard commented 6 years ago

There are some relevant comments here: https://phabricator.haskell.org/D4846

alpmestan commented 6 years ago

Oh, then I'll just go with the "always defined" direction suggested in the diff. Thanks! I'll update this branch once this is done.

snowleopard commented 6 years ago

Thanks @alpmestan!

alpmestan commented 6 years ago

I pushed an updated patch in my GHC branch (here) and relaunched the OS X build on travis: https://travis-ci.org/snowleopard/hadrian/jobs/425273841

alpmestan commented 6 years ago

@snowleopard Looks like we're good now: https://travis-ci.org/snowleopard/hadrian/jobs/425273841

It errors out later but I have no idea why it starts building things under _build/stage2, it's supposed to stop right before, right? Any idea what's going on? It otherwise looks like we're done with the findPtr issue.

snowleopard commented 6 years ago

@alpmestan Cool! Can you do the same with the CircleCI script?

alpmestan commented 6 years ago

In the meantime, I opened a diff for the GHC patch: https://phabricator.haskell.org/D5138

@snowleopard Yes, I can.

alpmestan commented 6 years ago

Done. Let's see how it goes. Any idea for my question above?

snowleopard commented 6 years ago

@alpmestan Thanks! Yes, I'll merge once CircleCI completes.

Sorry, I somehow missed your question. We are building Haddock and ghctags in Stage2 now, because this is what Make does. See this issue: #661.

alpmestan commented 6 years ago

@snowleopard OK. It's a bit annoying that this gets us riiiiiiiiiiiight past the timeout limit... :-(

alpmestan commented 6 years ago

Just a reminder to myself to make another PR when my diff gets merged, to not check out my branch anymore

alpmestan commented 6 years ago

https://github.com/snowleopard/hadrian/pull/690