Closed alpmestan closed 6 years ago
@alpmestan I'm afraid we already tried the #if defined(DEBUG)
trick -- and it doesn't work. We don't process Cabal files with CPP.
There are some relevant comments here: https://phabricator.haskell.org/D4846
Oh, then I'll just go with the "always defined" direction suggested in the diff. Thanks! I'll update this branch once this is done.
Thanks @alpmestan!
I pushed an updated patch in my GHC branch (here) and relaunched the OS X build on travis: https://travis-ci.org/snowleopard/hadrian/jobs/425273841
@snowleopard Looks like we're good now: https://travis-ci.org/snowleopard/hadrian/jobs/425273841
It errors out later but I have no idea why it starts building things under _build/stage2
, it's supposed to stop right before, right? Any idea what's going on? It otherwise looks like we're done with the findPtr
issue.
@alpmestan Cool! Can you do the same with the CircleCI script?
In the meantime, I opened a diff for the GHC patch: https://phabricator.haskell.org/D5138
@snowleopard Yes, I can.
Done. Let's see how it goes. Any idea for my question above?
@alpmestan Thanks! Yes, I'll merge once CircleCI completes.
Sorry, I somehow missed your question. We are building Haddock and ghctags
in Stage2 now, because this is what Make does. See this issue: #661.
@snowleopard OK. It's a bit annoying that this gets us riiiiiiiiiiiight past the timeout limit... :-(
Just a reminder to myself to make another PR when my diff gets merged, to not check out my branch anymore
I'm hoping to see the OS X travis job go green... =)