search

snowleopard / hadrian

Hadrian: a new build system for the Glasgow Haskell Compiler. Now merged into the GHC tree!
https://gitlab.haskell.org/ghc/ghc/tree/master/hadrian
MIT License
208 stars 37 forks source link

Move to GHC 8.4.3 by upgrading the Stackage snapshot #680

Closed ndmitchell closed 6 years ago

ndmitchell commented 6 years ago

At least compiles Hadrian itself, so this seems like a much better prospect - as it is Hadrian is close to getting outside the GHC support Window of last 2 versions.

snowleopard commented 6 years ago

Thanks @ndmitchell! GHC should be buildable with the previous two major GHC releases, and I guess Hadrian should be buildable by the previous two major GHC releases too. This currently includes GHC 8.2.*.

Should we bump to lts-11.22 (the latest including GHC 8.2.2) instead until GHC 8.6.1 is out?

ndmitchell commented 6 years ago

Yes, Hadrian should be buildable with 8.2, and it is. But why make people use an older GHC than is necessary? Using the latest GHC seems the right default.

snowleopard commented 6 years ago

But why make people use an older GHC than is necessary?

Just to provide faster feedback to Hadrian developers -- if they accidentally use a feature unavailable in GHC 8.2 and/or GHC-bundled libraries, they'll get a build failure. (Will they?)

They also get feedback from CI bots, but it's slower.

I guess the only (?) benefit of using the latest LTS is that we can use the latest non-GHC-bundled libraries?

ndmitchell commented 6 years ago

Shouldn't newer GHC's compile faster and print out less warnings? I guess I can see it both ways so whatever you prefer.

snowleopard commented 6 years ago

Shouldn't newer GHC's compile faster and print out less warnings?

I'm not sure why it would compile faster (newer GHCs aren't always faster), but I agree about warnings -- that's a good point.