search

snowleopard / selective

Selective Applicative Functors: Declare Your Effects Statically, Select Which to Execute Dynamically
MIT License
202 stars 21 forks source link

Dev maybe t #52

Open turion opened 2 years ago

turion commented 2 years ago

See https://github.com/snowleopard/selective/pull/39#issuecomment-1164093318 and https://github.com/snowleopard/selective/issues/37#issuecomment-1162756271

turion commented 2 years ago

Ah, the whole deriving via story doesn't work on older GHCs. Which makes this refactoring a bit pointless. If it's fine for you I'll leave this PR hanging round until maybe one day those older versions are dropped.

snowleopard commented 2 years ago

Hmm, unlocking DerivingVia seems like a pretty solid reason to drop support for older GHCs.

@vrom911 I can see that validation-selective currently supports GHC 8.4. How sad will you be if selective stops supporting it?

snowleopard commented 1 year ago

I went ahead and dropped support for older GHC versions, so we can now use DerivingVia!

Would you like to finish this PR? Happy to do this myself since I made some changes that might make rebasing this a bit tedious.

turion commented 1 year ago

Feel free to do it yourself, I can't come back to it in the next few weeks.

Kleidukos commented 9 months ago

@snowleopard I can probably make that kind of call regarding validation-selective in the future, since @tomjaguarpaw and I are maintainers for the lib now. :)

snowleopard commented 8 months ago

@Kleidukos Cool, thanks :) What's the last version of GHC that you support?

tomjaguarpaw commented 8 months ago

9.8

snowleopard commented 8 months ago

9.8

@tomjaguarpaw Oops, sorry, I meant to ask about the oldest supported version.

tomjaguarpaw commented 8 months ago

8.6, as confirmed by our test suite: https://github.com/kowainik/validation-selective/blob/a99a6610958090e55fa48ab936736471f1589691/.github/workflows/ci.yml#L24.

snowleopard commented 8 months ago

Got it, thanks! With #78 landing, selective supports the same version range, though I wonder if I should drop a few older versions. It's unclear if it's worth supporting so many versions.

tomjaguarpaw commented 8 months ago

What's the cost to supporting them?

snowleopard commented 8 months ago

What's the cost to supporting them?

CPP noise, CI time, and even just needing to think about them.

tomjaguarpaw commented 8 months ago

Yeah, it's hard to know whether the cost is worth paying without knowing how many people are continuing to use the package on older versions.