search

snowplow-archive / factotum-server

10 stars 2 forks source link

[WIP] code review #2

Closed ninjabear closed 7 years ago

ninjabear commented 7 years ago

Initial code review only - no need to merge

jbeemster commented 7 years ago

Integration notes:

  1. /check endpoint does not work
    • If there is an issue with the persistence or with the id supplied then an error should be returned; currently is just blank text
  2. /status endpoint does not need to report success or failure counts
  3. DryRun validation failures do not provide any information that can be used in debugging at the moment - this can be added as a ticket for the next release
  4. /status the version field is denoted by executor:
"version": {
  "executor": "0.1.0-rc3"
},

// CHANGE TO

"version" : "0.1.0-rc3"