search

snowplow-archive / schema-guru

JSONs -> JSON Schema
http://snowplowanalytics.com
150 stars 20 forks source link

Release/0.6.2 #164

Closed chuwy closed 8 years ago

chuwy commented 8 years ago

Opening new PR, since github doesn't allow me reopen it with force-pushed branch #158

alexanderdean commented 8 years ago

Hey @chuwy - the PR looks good but I'm not convinced by this commit message:

 Fixed incorrect type suggestion for integer with null (closes #157)

I think it would be better if that ticket was renamed to "Bump schema-ddl library to 0.3.1", because that is a better description of that commit, and the library bump fixes a couple of other things too...

chuwy commented 8 years ago

@alexanderdean absolutely agree.

chuwy commented 8 years ago

@alexanderdean fixed.

alexanderdean commented 8 years ago

This is released! @chuwy please add a Discourse post for this on Monday (mentioning the schema-ddl release too)...