snowplow-archive / sluice

A Ruby toolkit for cloud-friendly ETL
38 stars 10 forks source link

Remove problematic contract on Sluice::Storage::S3::rename_file #48

Closed alexanderdean closed 8 years ago

alexanderdean commented 8 years ago

Getting:

Contract violation for argument 3 of 3: Expected: (Proc or Bool), Actual: #<Contract:0x2fb1657c @args_contracts=[String, String], @has_options_contract=false, @args_validators=[#<Proc:0x4d3bd23f@uri:classloader:/gems/contracts-0.11.0/lib/contracts/validators.rb:51 (lambda)>, #<Proc:0x4d3bd23f@uri:classloader:/gems/contracts-0.11.0/lib/contracts/validators.rb:51 (lambda)>], @ret_validator=#<Proc:0x4d3bd23f@uri:classloader:/gems/contracts-0.11.0/lib/contracts/validators.rb:51 (lambda)>, @method=#<Proc:0x12684db6@uri:classloader:/emr-etl-runner/lib/snowplow-emr-etl-runner/s3_tasks.rb:56 (lambda)>, @klass=Snowplow::EmrEtlRunner::S3Tasks, @ret_contract=String, @args_contract_index=nil, @has_proc_contract=false, @pattern_match=false> Value guarded in: Sluice::Storage::S3::rename_file With Contract: String, Maybe, Or => Maybe At: uri:classloader:/gems/sluice-0.3.2/lib/sluice/storage/s3/s3.rb:579 

I think this contract as running in JRuby is just too complex...