snowplow-devops / terraform-google-bigquery-loader-pubsub-ce

Other
1 stars 2 forks source link

Credit Original Author #11

Closed tnightengale closed 2 weeks ago

tnightengale commented 3 weeks ago

Hey @jbeemster ,

I recently became aware of this module in a discussion during an interview. The interviewer looking at my Github and my older module questioned the source of this module.

The implication was that I made my own module rather than work within Snowplow's open source ecosystem.

A worse misunderstanding for my professional reputation might be that I copied this module.

Glancing at this module, it does seem like the initial commits are incredibly similar to my module. I know we spoke back in late 2022 about moving my module under the official Snowplow DevOps org and I didn't stay on top of the extended request to sign a contributor license agreement.

If indeed you proceeded with using sections of my module would you mind crediting that in some way on this project? I would like to archive my older module, as obviously this is the official version, and is actively maintained. However, it would be nice to have my efforts recognized.

Thanks,

Teghan

Screenshot 2024-08-19 at 4 19 42 PM

Screenshot 2024-08-19 at 4 19 42 PM (2)

jbeemster commented 3 weeks ago

Hi @tnightengale have added a PR here if this works for you? https://github.com/snowplow-devops/terraform-google-bigquery-loader-pubsub-ce/pull/12

The CLA details are here if you could please sign them and then ill get that notice merged in: https://docs.snowplow.io/docs/contributing/contributor-license-agreement/

tnightengale commented 3 weeks ago

Thanks @jbeemster!

And thank you for adopting and improving the initial work!

12 lgtm, but would you mind approving the suggested change so I will appear as a contributor to this project?

tnightengale commented 3 weeks ago

Also, I have signed the CLA.

Screenshot 2024-08-21 at 9 31 06 AM