search

snowplow-incubator / sauna

:hotsprings: A decisioning and response platform
https://github.com/snowplow/sauna/wiki
69 stars 11 forks source link

Fix error reporting of parseConfig #100

Closed trevorsibanda closed 7 years ago

trevorsibanda commented 7 years ago

This fix will enable errors which occur due to failed parsing of configs to be reported.

The error message will include the className as well as the exception message 

java.lang.RuntimeException: Cannot parse configuration [HipchatConfig]. Make sure its valid JSON version of Avro instance
Expected field name not found: token
    at scala.sys.package$.error(package.scala:27)
    at com.snowplowanalytics.sauna.SaunaOptions$.parseConfig(SaunaOptions.scala:263)
alexanderdean commented 7 years ago

Hey @trevorsibanda - I don't think you need to submit this as a separate PR. Instead:

  1. Create a GH issue for this in your 0.3.0 milestone
  2. Add this commit into one of your PRs