search

snowplow-incubator / sauna

:hotsprings: A decisioning and response platform
https://github.com/snowplow/sauna/wiki
69 stars 11 forks source link

Release/0.2.0 #80

Open alexanderdean opened 7 years ago

alexanderdean commented 7 years ago

Hi @BenFradet - can you do an initial code review pass on this? This is much more about coding style than about QA (I don't expect you to test all these observers/responders - will ask Anton to do this)...

alexanderdean commented 7 years ago

Thanks @BenFradet . @rzats please action these changes and then ping @BenFradet again. Then ask me for next steps.

alexanderdean commented 7 years ago

@rzats - can you make sure each commit has a ticket, or is merged into a commit that does.

I'm seeing:

notify() -> notifyLogger()

as its own commit.

alexanderdean commented 7 years ago

@BenFradet - can you take another pass at this?

rzats commented 7 years ago

@BenFradet addressed all of your comments - please let me know if this is OK!

rzats commented 7 years ago

@chuwy can you please do one final round of reviews?

chuwy commented 7 years ago

Will do!

alexanderdean commented 7 years ago

Hey @BenFradet - your review is still showing an X, can you switch it to an Approve?

@chuwy can you do your review in two phases please:

  1. Code review (should be fast given the iterations with Ben)
  2. Smoke testing - checking that the setup instructions make sense and the integrations work as advertised
alexanderdean commented 7 years ago

Legend, thanks @chuwy !

alexanderdean commented 7 years ago

Hey @rzats - can you crack on with the blog post whilst waiting for Chuwy's smoke tests? Thanks!