stanch
commented
1 year ago If you look at the git history, we normally name commits like (close #129) not just (#129). If you care about consistency, you could rebase the branch and rename the commits.
That’s because I did not create the corresponding issues, so #129 and #130 are PR numbers. Sorry!
I suspect there is a misunderstanding of what the option does (which I promise will be explained in the announcement and the docs in due time!) It does not change the format at all!
- Micro now always logs events. The purpose of this new feature is to aid debugging. All logs go to STDERR (sic!) and contain various decoration, like
[INFO]etc. You can control them with-Dorg.slf4j.simpleLogger.log.EventLog=offto turn off the event logs specifically, or-Dorg.slf4j.simpleLogger.defaultLogLevel=offto turn off all logs. Or you can change the logging format entirely to your liking. - Outputting TSV is completely independent and is to STDOUT (sic!). If you enable it, you will have both the logs and the TSV. For piping into other tools, which is the main purpose of this feature, it does not matter (or may even help, so that you still see you are receiving events without the need to jump through hoops with
teeor the like). However if both outputs are undesirable, you can either suppress the logs as above, or simply redirect STDERR to/dev/null.
With this in mind, I don’t think --tsv-events or --tsv are accurate, as they don’t convey that an additional action is happening. However, I can be convinced to change --print to --output-enriched-tsv or something like that, if you prefer.
greg-el
If you look at the git history, we normally name commits like
(close #129)not just(#129). If you care about consistency, you could rebase the branch and rename the commits. Give me a shout if you want help with that.Otherwise I think the release looks good, as long as @greg-el is happy with it too.