search

snowplow-referer-parser / referer-parser

Library for extracting marketing attribution data from referrer URLs
http://snowplowanalytics.com
359 stars 150 forks source link

Add identified mobile app referers #207

Closed robertdecaire closed 4 years ago

robertdecaire commented 5 years ago

These are mobile app referers that we have identified in our traffic, but which aren't being correctly parsed.

lukeindykiewicz commented 5 years ago

Hello Robert, thank you for preparing the PR! Could you please sign CLA, which can be found here: https://docs.google.com/forms/d/e/1FAIpQLSd89YTDQ1XpTZbj3LpOkquV_h1Y8k9ay3iFbJsZsJrz18I23Q/viewform

lukeindykiewicz commented 5 years ago

It would be super nice if you could follow our commit naming conventions. The commit name should be the same as the issue name followed by (closes #xx)

lukeindykiewicz commented 5 years ago

Oh, I see you've already signed it. Thank you!

robertdecaire commented 5 years ago

@lukeindykiewicz I'm not aware of an issue that this is intended to close. I was invited to submit a ticket to add additional values to the referers list as part of support ticket #18190 when we inquired about the possibility of getting an updatable referers list. We were informed that we can expect that updatable list to be added in R118, but that in the meantime, leading up to R117 you're accepting suggestions for updates to referers.yml.

If you can point me at an open issue that this would apply to, I'll update the commit name to match.

lukeindykiewicz commented 5 years ago

Hi @robertdecaire, thanks for explaining. Maybe there is no issue for that. No worries, I'll update the issue and the commit message. Yes, it's going to be included in the R117. Have a nice day.