search

snowplow / dataflow-runner

Run templatable playbooks of Hadoop/Spark/et al jobs on Amazon EMR
http://snowplowanalytics.com
19 stars 8 forks source link

Fix hardcoded application version #23

Closed chuwy closed 7 years ago

chuwy commented 7 years ago

https://github.com/snowplow/dataflow-runner/blob/master/src/main.go#L34

alexanderdean commented 7 years ago

Is the plan to fetch this at build time from the VERSION file?

BenFradet commented 7 years ago

I was thinking of updating it as part of the "Prepared for release" commit like the other artifacts.

alexanderdean commented 7 years ago

That's fine, per https://github.com/snowplow/sql-runner/commit/5dc8dffc3cb8919e8840733f250ad72fb4aba8c5

BenFradet commented 7 years ago

Descheduling and closing since this is part of the "Prepared for release commit": 49b9fd0c9c16e8e81ac503d29b3cb9ed560855c3