Fix issue for direct channel group logic - Githubissues

snowplow / dbt-snowplow-unified

A fully incremental model, that transforms raw web & mobile event data generated by the Snowplow JavaScript & mobile trackers into a series of derived tables of varying levels of aggregation.

Other

12 stars 5 forks source link

Fix issue for direct channel group logic #44

Closed rlh1994 closed 6 months ago

rlh1994 commented 6 months ago

Description

This PR fixes an issue where the string was based on an old regex lookup. Comparing to our tracked data these values seem more correct.

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[x] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑‍💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents

https://snplow.atlassian.net/browse/PE-6334

Checklist

[x] ❗️ I have verified that these changes work on Redshift
[ ] 💣 Is your change a breaking change?
[ ] 📖 I have updated the CHANGELOG.md

Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📓 internal package docs (ymls, macros, readme, if applicable)
[ ] 📕 I have raised a Snowplow documentation PR if applicable (Link here if required)
[x] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?