snowplow / dbt-snowplow-unified

A fully incremental model, that transforms raw web & mobile event data generated by the Snowplow JavaScript & mobile trackers into a series of derived tables of varying levels of aggregation.
Other
12 stars 5 forks source link

modified tests #81

Closed OscarSnowPlow closed 1 month ago

OscarSnowPlow commented 1 month ago

Description

What type of PR is this? (check all applicable)

Related Tickets & Documents

https://snplow.atlassian.net/browse/PE-6608

It was highlighted that if you set the parameters up in a particular way (described in ticket above) the code would run successfully as intended but if you were to run a dbt test 8 column tests would fail because those columns are not showing with this particular set up.

To fix I modified the columns test which were all not null test from the yaml files. I replaced these with condition which only runs the test if a particular specification is met.

Checklist

Added tests?

Added to documentation?

Are there any post-deployment tasks we need to perform?

Maybe an update on documentation.

OscarSnowPlow commented 1 month ago

I have tested on my side feel free to checkout the branch and run your own test

Let me know if you have any questions or suggestions