Rework filter bots macro - Githubissues

snowplow / dbt-snowplow-unified

A fully incremental model, that transforms raw web & mobile event data generated by the Snowplow JavaScript & mobile trackers into a series of derived tables of varying levels of aggregation.

Other

12 stars 5 forks source link

Rework filter bots macro #86

Closed agnessnowplow closed 1 month ago

agnessnowplow commented 1 month ago

Description

This PR makes sensible adjustments in the filter_bots() macro based on user request.

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[x] 🧑‍💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents

https://snplow.atlassian.net/browse/PE-6533

Checklist

[ ] 💣 Is your change a breaking change?
[ ] 📖 I have updated the CHANGELOG.md

Added tests?

[ ] 👍 yes
[ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📓 internal package docs (ymls, macros, readme, if applicable)
[ ] 📕 I have raised a Snowplow documentation PR if applicable (Link here)
[ ] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?