search

snowplow / dbt-snowplow-utils

Snowplow utility functions to be used in conjunction with the snowplow-web dbt package.
Other
12 stars 6 forks source link

If events are missing dvce_created_tstamp those events will be missing in base tables #174

Closed stevensnicholas closed 1 month ago

stevensnicholas commented 2 months ago

There is the use of dvce_created_tstamp is in a predicate in the macro https://github.com/snowplow/dbt-snowplow-utils/blob/19d16b37c9bbf324a70037859ef608e3fffb004f/macros/base/base_create_snowplow_sessions_lifecycle_manifest.sql#L65 . If events are processed and contain dvce_created_tstamp they will be missing

miike commented 2 months ago

@stevensnicholas Could you clarify what you mean by this?

If events are processed and contain dvce_created_tstamp they will be missing

This logic looks like as long as the dvce_created_tstamp is within the days_late_allowed threshold (when compared to dvce_sent_tstamp) it should be included in the model.

stevensnicholas commented 2 months ago

Sorry, that was a poorly worded title - if either dvce_created_tstamp or dvce_sent_tstamp are null those rows will be missing from events this run. Because either side of that where clause will be comparing to null.

miike commented 2 months ago

Thanks - that makes sense let me raise with the team.

miike commented 2 months ago

Linking #176 as an update courtesy of the brilliant @agnessnowplow

agnessnowplow commented 1 month ago

Closing as this should now be solved with the latest release.