search

snowplow / enrich

Snowplow Enrichment jobs and library
https://snowplowanalytics.com
Other
21 stars 40 forks source link

Stream Enrich: Fix the enrichment order #662

Closed spenes closed 2 years ago

spenes commented 2 years ago

In version 3.2.0, we've made change on the enrichment order. Details can be found here.

The original problem was only on the enrich-kinesis and enrich-pubsub. Enrichment order on the stream-enrich was correct. During this change, we've introduced legacyEnrichmentOrder flag to fix order in enrich-kinesis and enrich-pubsub without making this breaking change. legacyEnrichmentOrder = true means preserve the wrong order used in the enrich-kinesis and enrich-pubsub.

The problem is we've set legacyEnrichmentOrder to true in the stream-enrich as well this means using the wrong enrichment order instead of correct one in the stream-enrich. We've should make it false.

istreeter commented 2 years ago

For reference, I will document here the correct enrichment order, and the mistaken enrichment order.

Correct order

Incorrect order