Closed adatzer closed 9 months ago
Edit: Have tested this implementation both with the mobile and JS trackers, it works nicely, great work!
Hi Enes! Thank you very much for reviewing and for creating the cleanup branch. This was really helpful! I have cherry-picked your commit as is, and also applied scalafmt.
The additional Make edits
commit includes some edits related to:
cross-navigation
schema (pending final review). Since the timestamp
and the domain_user_id
props are required, we decided that if they are missing, the enrichment should not add the corresponding entity at all, i.e. this is considered invalid extended format.filterNot
was removed.Additionally, this PR has 2 iglu-central pull requests as dependencies:
Please let us know what you think of these last changes and whether there is anything else to be done from our side. Thanks once again!
cc @igneel64 @greg-el @matus-tomlein
Moved to https://github.com/snowplow/enrich/pull/856, closing this one.
This pull request adds an enrichment that can parse the extended cross navigation format in
_sp
querystring parameter and attach thecross_navigation
context to an event.The extended cross navigation format can be described by
_sp={domainUserId}.{timestamp}.{sessionId}.{subjectUserId}.{sourceId}.{platform}.{reason}
The changes in the trackers to allow this extended format can be seen in:
The corresponding iglu-central pull requests are:
cross_navigation
context schemacross_navigation_config
enrichment schemacc @greg-el @igneel64 @matus-tomlein