search

snowplow / iglu-central

Contains all JSON Schemas, Avros and Thrifts for Iglu Central
http://iglucentral.com
Apache License 2.0
118 stars 114 forks source link

Add com.snowplowanalytics.snowplow/client_session/jsonschema/1-0-3 (close #1410) #1411

Closed matus-tomlein closed 1 month ago

matus-tomlein commented 1 month ago

Issue #1410

This PR adds the 1-0-3 version of the client_session entity that has only one change compared to the 1-0-2 version: it makes the previousSessionId property non-required. The property is nullable, so making it non-required should not be a breaking change.

The reason for this update is a customer issue where their mobile apps in production seem to be tracking events with the entity but for some reason are omitting the null value. We are unable to reproduce and thus fix in the tracker, but we have seen this in the past a few times, so making the schema resilient to this is the only option for us.

Also making the schema supersede the 1-0-2 schema so that it is automatically applied to events tracked with the 1-0-2 entity.

It is somewhat urgent as the customer is pushing for us since they are seeing failed events in production.

jbeemster commented 1 month ago

Waiting for green-ticks @matus-tomlein and I can then merge it in.

matus-tomlein commented 1 month ago

@jbeemster can you please merge it in when you have the chance (also happy to put together a release PR, just let me know)?

As Ian noted, this is the first time that we add schemas with a supersedes relationship to Iglu Central, so we should be a bit more careful here. Also the client_session schema is a very popular one, almost all mobile apps track it.

jbeemster commented 1 month ago

@matus-tomlein can you please prepare the release PR and ill take a look and merge. Going to need to enable patches on our Iglu Central server mirrors as well to allow for this change.

matus-tomlein commented 1 month ago

Cherry picked into release #1412