search

snowplow / iglu-central

Contains all JSON Schemas, Avros and Thrifts for Iglu Central
http://iglucentral.com
Apache License 2.0
118 stars 114 forks source link

Redshift SQL: patch for com_snowplowanalytics_snowplow_timing_1 #531

Open alexanderdean opened 7 years ago

alexanderdean commented 7 years ago

Make the timing column a BIGINT, not an INT.

Migrated to https://github.com/snowplow/snowplow/issues/2818

ihortom commented 7 years ago

See https://snowplow.zendesk.com/agent/tickets/5238 for latest context

alexanderdean commented 7 years ago

This ticket assumes that we want to put bigint limits on the schema and bump the Redshift type to bigint too. Not sure if this makes total sense given this is meant to represent a timing - how big can an elapsed duration be? /cc @chuwy and @BenFradet

ihortom commented 7 years ago

Another related issue: https://github.com/snowplow/iglu-central/issues/382

chuwy commented 7 years ago

Is this schema supposed to be used only by JavaScript tracker? If so then maximum duration with INTEGER is 24 days (2147483647 / 1000 / 3600 / 24) looks more than enough for web page. Having that I think we should fix JSON Schema, not Redshift table.

alexanderdean commented 7 years ago

Closing in favour of #382.

alexanderdean commented 7 years ago

Reopening, sorry for confusion.