snowplow / iglu-central

Contains all JSON Schemas, Avros and Thrifts for Iglu Central
http://iglucentral.com
Apache License 2.0
118 stars 114 forks source link

Consent docs and schema discrepency #780

Open ihortom opened 6 years ago

ihortom commented 6 years ago

There's a discrepancy in our docs. The schema accepts strings but all the docs suggest integers:

The users read the docs and implement required values as integer which result in getting consent related events ended up in bad bucket. See https://snowplow.zendesk.com/agent/tickets/9418 as an example

mhadam commented 6 years ago

The docs should be updated to accept strings, as they are in the other trackers.

alexanderdean commented 6 years ago

@mhadam will you tackle this please?

alexanderdean commented 6 years ago

See also: https://github.com/snowplow/snowplow-javascript-tracker/issues/652

mhadam commented 6 years ago

@ihortom I've update the documentation, this can be closed now.

ihortom commented 6 years ago

@mhadam, the blog article contains example with integers rather than strings. Could you correct that as well, please?

mhadam commented 6 years ago

Ah yes, will do that now. Opened a pull-request here, should be fixed soon: https://github.com/snowplow/snowplowanalytics.com/pull/716