search

snowplow / iglu

Iglu is a machine-readable, open-source schema repository for JSON Schema from the team at Snowplow
http://www.snowplow.io
Apache License 2.0
208 stars 45 forks source link

Iglu tasks #484

Closed aldemirenes closed 4 years ago

snowplowcla commented 5 years ago

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://github.com/snowplow/snowplow/wiki/CLA to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

aldemirenes commented 5 years ago

I signed it!

aldemirenes commented 5 years ago

Hi @chuwy ! I realized that you force-pushed to redshift-migrations branch. Since I worked on the old version of redshift-migrations branch, a lot of conflict happened in this PR after force-push. Should I rebase the commits in this PR to last version of the redshift-migrations branch ?

aldemirenes commented 5 years ago

Thanks for the review @rzats ! I made changes according to your feedbacks. Also, I tried to rebase to the latest version of redshift-migrations branch however I could not compile to project due to some changes on the last experimental commits. Therefore, I rebased my branch to https://github.com/snowplow/iglu/commit/b389ae3aa24ca3244854a0a029c5fcc13cc51778. I can rebase to the latest version of the redshift-migrations branch after working on that branch end.

aldemirenes commented 5 years ago

Hey @chuwy! Just a heads-up, I made necessary changes according to your comments!

chuwy commented 4 years ago

These projects migrated to their own repos.