snowplow / iglu

Iglu is a machine-readable, open-source schema repository for JSON Schema from the team at Snowplow
http://www.snowplow.io
Apache License 2.0
208 stars 45 forks source link

Feat/submodules #528

Closed adatzer closed 2 years ago

adatzer commented 2 years ago

A preview of the final outcome after merging and running the submodules_update github action can be seen in this temporary fork here.

adatzer commented 2 years ago

Thank you for reviewing @paulboocock ! Concerning the snowplow-iglu server helm chart, it would be great to reference as well. Indeed, though, submodules need to be git repositories, so we cannot add only the relevant subdirectory as a submodule. The alternatives i have considered so far are:

Each of the above has its pros and cons and i am not sure which makes more sense. What do you think?

adatzer commented 2 years ago

The rebase force-pushed includes:

  1. Reorder of commits to allow setting the new url for igluctl and iglu-server
  2. Switch to snowplow.io domain (included in "Update Readme files" commit)
  3. Cherry-pick of commit from https://github.com/snowplow/iglu/pull/483
  4. Issue https://github.com/snowplow/iglu/issues/529

Temporary test repository with the rebased PR merged.