snowplow / scala-weather

High-performance Scala library for looking up the weather
https://snowplow.github.io/scala-weather/
45 stars 13 forks source link

Release 1.0.0 back to develop #131

Closed lukeindykiewicz closed 4 years ago

benjben commented 4 years ago

Should be only Prepare for release commit

lukeindykiewicz commented 4 years ago

Should be only Prepare for release commit

What do you mean by that? I have removed the Bump to 1.0.0 commit.

lukeindykiewicz commented 4 years ago

If you mean any other commit in this branch, no it shouldn't. It was explained in the mirror PR to master, please check: https://github.com/snowplow/scala-weather/pull/130#issue-474907941

That's due to change to gitflow workflow in the middle of this "release"

This both PRs are a pair. I also write in internal channel that the develop branch was forced pushed to be prepared according to gitflow-workflow, but not before any PR in this release.

benjben commented 4 years ago

are already on develop. Do not hesitate to force-push to develop so that we can start using gitflow as we should.

lukeindykiewicz commented 4 years ago

develop is mirroring master now, should be possible to work with gitflow workflow from now on