search

snowplow / snowbridge

For replicating streams across clouds, accounts and regions
Other
15 stars 7 forks source link

Revamp unit testing project-wide (closes #129) #139

Closed TiganeteaRobert closed 2 years ago

TiganeteaRobert commented 2 years ago

Created new branch from release/1.0.0 to skip solving conflicts.

This PR concludes the revamp of the unit testing. From a throughout investigation I've found only one file (serverless.go) where we were missing unit tests (it is a testing asset but I added an unit test nevertheless), the other changes are fixes for all unit tests and integration tests to run locally.

Initial PR: https://github.com/snowplow-devops/stream-replicator/pull/135

colmsnowplow commented 2 years ago

@adatzer I think you can take this review, I don't think it needs further review to get it into release/1.0.0 branch once approved

Myself and Robert will be reviewing/rubber-ducking this together informally too.

Keep in mind that this PR may affect the transform/custom PR, and one or the other will likely need to be rebased.

colmsnowplow commented 2 years ago

Removed reviewers - there's still a good few gaps in testing that we need to cover first.

colmsnowplow commented 2 years ago

OK @adatzer this should be ready for review now.

There are three commits in here each with their own issue. Then I've separated the kafka source from the rest because that has a bug that I don't have time to dig into. For now, don't worry about the kafka source stuff, it will need to be dealt with separately from the rest.

cc @TiganeteaRobert - I somehow overwrote the parts you wrote in the rebase - not sure how I did that, but if you like you can take a look through this PR to see what I've done for pubsub etc. It's not perfect but I think it impoves our functionality coverage. Will be in touch to discuss plan for kafka source.

colmsnowplow commented 2 years ago

Closing in favour of rebased PR: https://github.com/snowplow-devops/stream-replicator/pull/165