search

snowplow / snowbridge

For replicating streams across clouds, accounts and regions
Other
15 stars 7 forks source link

Extend unit tests #165

Closed colmsnowplow closed 2 years ago

colmsnowplow commented 2 years ago

This PR replaces https://github.com/snowplow-devops/stream-replicator/pull/139, as it required a rebase and it was simple to just create a new PR.

colmsnowplow commented 2 years ago

Thanks @adatzer you've pointed out some useful things here. Going to take another pass at them tomorrow and see if I can improve this PR a bit.

Side note given we are on testing: would we rename transform_test_variables.go to transform_variables_test.go to follow the test suffix convention?

I think I initially did it that way as it's not testing a file named variables, it's a set of variables for tests. But I dunno if that actually makes any sense - I'll think about it after I address the comments.

colmsnowplow commented 2 years ago

Thanks for very useful comments @adatzer - I'm a lot happier with the state of affairs now.

I think I've addressed everything now, should be ready for another pass.