search

snowplow / snowbridge

For replicating streams across clouds, accounts and regions
Other
15 stars 7 forks source link

Clean up tls configuration #177

Closed colmsnowplow closed 2 years ago

colmsnowplow commented 2 years ago

Kafka and http targets allow tls configurations by providing files. In our deployment model it's far easier to provide the tls file contents as b64 and provide them as env vars. Change the configuration to suit.

colmsnowplow commented 2 years ago

In review, we revised this decision and decided that providing tls files to the environment should be the responsibility of deployment: https://github.com/snowplow-devops/stream-replicator/pull/143#discussion_r928104260

We rebased out those portions of this commit. However we didn't revert it completely, and kept some of the changes in instrumenting it.

So, rather than just closing this issue, I'm renaming it to clean up tls configurations, and recording this decision here in case it informs some future debugging.