search

snowplow / snowbridge

For replicating streams across clouds, accounts and regions
Other
15 stars 7 forks source link

Release/0.4.0 #66

Closed colmsnowplow closed 3 years ago

colmsnowplow commented 3 years ago

This is the release PR for the first addition of filtering.

It contains all of the changes from https://github.com/snowplow-devops/stream-replicator/pull/60, squashed into one commit, as well as fixes for lint issues across the project.

Apologies for needing to create a new PR, I forgot I wasn't on a release branch. Hoping it's easy enough to approve since the difference is minimal.

The only thing to call out is that I changed some previously exported methods to be unexported in order to appease the linter - I think this doesn't cause problems but not 100% certain.

Release TODO (once any change requests are resolved):

colmsnowplow commented 3 years ago

@paulboocock I agree on load testing - is there any other kind of testing for filtering that we think is necessary, or would you think that the unit tests I've written should suffice?

paulboocock commented 3 years ago

@paulboocock I agree on load testing - is there any other kind of testing for filtering that we think is necessary, or would you think that the unit tests I've written should suffice?

I think the unit tests, along with the popular fields we expect to be used being tested manually is sufficient.