Open nakulgan opened 7 years ago
SGTM - @jbeemster ?
@nakulgan sounds good!
The general flow for the mobile trackers is as follows:
One caveat on the above is the case of events that are too big. This generally means events above 50000 bytes in size - we handle these cases by still sending the event but we do not care about the return code and always remove them from persistent storage.
You can see some of this process explained in this blog post: http://snowplowanalytics.com/blog/2015/10/08/snowplow-unity-tracker-0.1.0-released/#features
Thanks @jbeemster Josh. Implementing the above flow pretty much covers this ticket and #4 as well.
I would move this to 0.5.0, #4 and #44 together make testing quite complex. I would prefer to add a mocking library Mockolate first to have proper tests.
@alexanderdean thoughts?
Hey @nakulgan - I think this was one of the things our customer was really looking for, so I don't think we can push back. But we can certainly add whatever additional testing scaffolding you see fit as additional tickets in this release...
Please update commit title!
Currently, Requests that fail are added to an array. But are then lost.
See discussion here.
@alexanderdean @jbeemster thoughts?