Add missing flush API (close #679)

snowplow / snowplow-android-tracker

Snowplow event tracker for Android. Add analytics to your Android apps and games

http://snowplowanalytics.com

Apache License 2.0

109 stars 63 forks source link

Add missing flush API (close #679) #684

Open mscwilson opened 5 months ago

mscwilson commented 5 months ago

For issue #679

Exposes the Emitter flush() method

coreypett commented 4 months ago

Anything I can do to help get this merged?

mscwilson commented 4 months ago

After discussion within the team, we've decided to backburner this PR for now. The way the Emitter works is different between the Android and iOS trackers; we have plans to eventually update the Android code. For now, we're concerned that this change is too naive and could lead to unexpected behaviour - that flush() could be called but not do anything.