search

snowplow / snowplow-golang-tracker

Snowplow event tracker for Golang. Add analytics to your Go apps and servers
http://snowplowanalytics.com
Apache License 2.0
25 stars 14 forks source link

Replace myesui/uuid with google/uuid #59

Closed ChrisPenner closed 3 years ago

ChrisPenner commented 3 years ago

Describe the bug This project depends on https://github.com/myesui/uuid ; which appears to have disappeared from the face of Github. The repo 404's and the user themself was apparently created only a week ago? Very strange.

> go mod vendor
go: github.com/snowplow/snowplow-golang-tracker/v2@v2.0.0-20201008204249-2caa93314ceb requires
        github.com/myesui/uuid@v1.0.0: reading github.com/myesui/uuid/go.mod at revision v1.0.0: unknown revision v1.0.0

To Reproduce Depend on snowplow/snowplow-golang-tracker and run go mod vendor

Expected behavior Don't depend on non-existent projects

Obviously this isn't your fault, and maybe that repo will come back? Not sure what's going on, but it may be worthwhile depending on a more reliable uuid package regardless. Cheers!

jbeemster commented 3 years ago

Hi @ChrisPenner thanks for the report! It looks like a dependency of a dependency as we are using twinj in the direct references within the library where we need a UUID. Will have to see where this transitive dep is coming in from..

jredl-va commented 3 years ago

I feel we need to use a different uuid framework:

image

Would you be open to a pull request that uses: https://github.com/google/uuid

jbeemster commented 3 years ago

Hi @jredl-va - PR's are always welcome! Using something non-archived and maintained is definitely a better option...

dmateus commented 3 years ago

Hi @jbeemster - I'm a backend engineer at https://github.com/getground. We're using this library and would love to PR this change: replace myesui/uuid with google/uuid

Do I need repo permissions? Also do I need to sign a CLA?

paulboocock commented 3 years ago

Hey @dmateus Thanks for reaching out. You don't need any particular permissions for this, you can fork the repository, make your changes and then open a PR from your fork into master. When you open the PR, a bot will pop up that will ask you to complete the CLA and then add a comment to tell the bot you've done it. Once thats done, we can look at merging the PR and getting a release out. I should have time to do this reasonably soon, probably early next week.