search

snowplow / snowplow-gtm-server-side-tag

A Google Tag Manager Server-side Tag template for sending events to a Snowplow Collector
Apache License 2.0
5 stars 2 forks source link

Update log format #7

Closed Bukashk0zzz closed 2 years ago

Bukashk0zzz commented 2 years ago

Init discussion https://github.com/snowplow/snowplow-gtm-server-side-tag/issues/6

Bukashk0zzz commented 2 years ago

I ping you with honor @paulboocock :)

paulboocock commented 2 years ago

It's on @adatzer's backlog, but shes pretty busy at the moment. We'll get to it in June though, I think thats the best I can promise at the moment.

Bukashk0zzz commented 2 years ago

Great. Thanks for the answer.

Bukashk0zzz commented 2 years ago

I am glad that you liked the idea of standardizing logs. And thanks for such an in-depth review.

If there are more detailed resources around the log standard you created at Stape, could you please let us know, in order to correctly apply across our other tags as well?

Currently not. But we plan to create a public repository where this will be described. There will be logging and probably a few other standards that we recommend to use for sGTM template writing. Hope this will be done by the end of Summer.

I saw you already prepared PR https://github.com/snowplow/snowplow-gtm-server-side-tag/pull/11 with the update. Do I need to update this PR to fix your findings? Or you will update all in your PR?

adatzer commented 2 years ago

Thank you very much for your feedback @Bukashk0zzz !

Currently not. But we plan to create a public repository where this will be described. There will be logging and probably a few other standards that we recommend to use for sGTM template writing.

Looking forward to it! Meanwhile, please feel free to open an issue to inform us on any updates.

Do I need to update this PR to fix your findings? Or you will update all in your PR?

Just made the updates in #11 according to our discussion here.

adatzer commented 2 years ago

Thank you very much once again for contributing @Bukashk0zzz ! Your PR has been included in #11 , which is now merged.