search

snowplow / snowplow-java-tracker

Snowplow event tracker for Java. Add analytics to your Java desktop and server apps, servlets and games. (See also: snowplow-android-tracker)
http://snowplowanalytics.com
Apache License 2.0
23 stars 36 forks source link

Deprecate Builder classes (close #355) #356

Closed mscwilson closed 2 years ago

mscwilson commented 2 years ago

This PR improves the API by deprecating the Builder classes in Tracker, BatchEmitter, Subject and the HttpClientAdapter classes (AbstractHttpClientAdapter, OkHttpClientAdapter, ApacheHttpClientAdapter).

The AbstractHttpClientAdapter class only had one parameter, with another parameter in the child classes: the Builder classes were only present for consistency. New constructors have been added. HttpClientAdapters aren't directly made via Configuration classes.

The Builders have been deprecated, not removed, so this is not a breaking change.

NB Builder methods are still used in the AbstractEvent and other Event classes.

github-actions[bot] commented 2 years ago

This pull request is for issue #355.