snowplow / snowplow-javascript-tracker

Snowplow event tracker for client-side and server-side JavaScript. Add analytics to your websites, web apps and servers.
http://snowplowanalytics.com
BSD 3-Clause "New" or "Revised" License
555 stars 222 forks source link

Fix snowplow ecommerce typename conflicts #1296

Closed igneel64 closed 8 months ago

igneel64 commented 8 months ago

Mistakenly it was not detected that the Snowplow ecommerce plugin exposes already two types Promotion and Transaction from the universal analytics ecommerce wrapper functionality. This overrides the definitions from other types exposed at 3.22.0.

To mitigate this we can rename the types Promotion and Transaction from the Snowplow Ecommerce package to SPPromotion and SPTransaction.

This would be bumped on a patch version.

bundlemon[bot] commented 8 months ago

BundleMon

Files added (6) Status | Path | Size | Limits :------------: | ------------ | :------------: | :------------: :white_check_mark: | libraries/browser-tracker-core/dist/index.mod
ule.js
| +26.51KB | 27KB / +10% :white_check_mark: | trackers/javascript-tracker/dist/sp.js
| +25.1KB | 25.5KB / +10% :white_check_mark: | trackers/javascript-tracker/dist/sp.lite.js
| +15.4KB | 16KB / +10% :white_check_mark: | trackers/browser-tracker/dist/index.umd.min.j
s
| +15.29KB | 15.5KB / +10% :white_check_mark: | libraries/tracker-core/dist/index.module.js
| +13.36KB | 15KB / +10% :white_check_mark: | trackers/browser-tracker/dist/index.module.js
| +3.51KB | 5KB / +10%

Total files change +99.17KB 0%

Final result: :white_check_mark:

View report in BundleMon website ➡️


Current branch size history

igneel64 commented 8 months ago

@matus-tomlein Shared the same thought. Reason I use the SP prefix is because other solutions (GA4 and UA) can be regarded as Ecommerce.