Open tkalfigo opened 7 years ago
When opening a PR, the tests should run with the correct credentials, unless I'm mistaken?
Hey @tkalfigo @BenFradet only PRs from within Snowplow get access to those credentials. Otherwise you could have someone open a PR with malicious changes to dump those credentials to plain text.
For more information: https://docs.travis-ci.com/user/environment-variables/#Defining-encrypted-variables-in-.travis.yml
I believe this issue can be closed?
Agree, closing
How do you expect contributors test their implementation before sending a pull request? Could you provide a wiki document, how to setup a saucelabs account and how to configure all moving parts? We do not feel confident sending a PR withouth prior successfully running the test suite. @alexanderdean, what do you think?
Good idea, re-opened and renamed ticket.
Some initial documentation is already on wiki: https://github.com/snowplow/snowplow/wiki/4-For-developers#54-tests, though requiring step-by-step guide and some rewording.
@chuwy I don't see how that wiki page helps devs who want to run the tests on a fork of the project as @christoph-buente requested. Also it seems outdated or inaccurate. I don't see a file tests/integration/request_recorder.js
mentioned therein. And of course doesn't explain what would need to be adopted to run the tests, locally or through travis (e.g. AWS and NPM deployment among others I see in travis.yml).
Running
grunt
does the build. Butgrunt test
fails at theintern:functional
task. It seems that it fails when opening the tunnel to SauceLabs due to missing credentials. Thegrunt test
output is:and in the generated
./SauceLabsTunnel.log
the last few entries are:Tried this both locally and on travis-ci.org, thinking that perhaps the
.travis.yml
env section would help:but got same output on both.
I'm doing this with latest version 2.8.2.
How do I get the functional tests on SauceLab to run?